[WIP] collation-generation: resolve mismatch between descriptor and commitments core index #7104
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmitments core index
7 tasks
sw10pa
added
I2-bug
alindima
reviewed
Jan 13, 2025
Comment on lines
+383
to
+386
| // Malicious behavior detected: The parachain is assigned to | ||
| // multiple cores but repeatedly selects the same core. This is | ||
| // unexpected and the process should stop here. | ||
| gum::error!(target: LOG_TARGET, "Parachain repeatedly selected the same core index"); |
There was a problem hiding this comment.
this is not malicious behavior, could be legitimately only building for one core (without elastic scaling). I would also demote this log to info level
|
|
||
| let descriptor_core_index = match commitments.core_selector() { | ||
| // If a valid CoreSelector is found, calculate the core index based on it. | ||
| Ok(Some((core_selector, _cq_offset))) => { |
There was a problem hiding this comment.
we should take into account the claim queue offset, if we do have a core selector
| core_selector.0 as usize % cores_to_build_on.len(); | ||
|
|
||
| if cores_to_build_on.len() > 1 && | ||
| prev_core_selector_index == core_selector_index |
There was a problem hiding this comment.
we're only checking if the previous core selector is the same, but what if the core selectors look like 1,2,1?
In this case we should stop after building for 1 and 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
[#7107] Core Index Mismatch in Commitments and Descriptor
Description
This PR resolves a bug where normal (non-malus) undying collators failed to generate and submit collations, resulting in the following error:
ERROR tokio-runtime-worker parachain::collation-generation: Failed to construct and distribute collation: V2 core index check failed: The core index in commitments doesn't match the one in descriptor.More details about the issue and reproduction steps are described in the related issue.
Summary of Fix
TODO