[XCM] add generic location to account converter that also works with external ecosystems #7313
+3,485
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
changed the title
|
Please review @acatangiu |
acatangiu
reviewed
Jan 27, 2025
Comment on lines
+122
to
+126
| pub type GlobalLocationToAccount<AccountId> = GenericLocationToAccountConverter< | ||
| AccountId, | ||
| (GlobalConsensusConvertsFor, GlobalConsensusParachainConvertsFor), | ||
| (DescribeAllTerminal, DescribeFamily<DescribeAllTerminal>), | ||
| >; |
There was a problem hiding this comment.
I'm not sure what this is trying to do, but doesn't look like it would work.
I added more details to the issue, hope that helps, please ping me for more details if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #7129 (comment)