[sync] Let new subscribers know about already connected peers (backward-compatible) #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --bump patch --audience node_dev |
dmitry-markin
added
the
A4-needs-backport
bkchr
approved these changes
Jan 27, 2025
EgorPopelyaev
approved these changes
Jan 27, 2025
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7344-to-stable2407
git worktree add --checkout .worktree/backport-7344-to-stable2407 backport-7344-to-stable2407
cd .worktree/backport-7344-to-stable2407
git reset --hard HEAD^
git cherry-pick -x ee30ec723ee22e247014217e48513a2e7690c953
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7344-to-stable2409
git worktree add --checkout .worktree/backport-7344-to-stable2409 backport-7344-to-stable2409
cd .worktree/backport-7344-to-stable2409
git reset --hard HEAD^
git cherry-pick -x ee30ec723ee22e247014217e48513a2e7690c953
git push --force-with-lease |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…rd-compatible) (#7344) Revert #7011 and replace it with a backward-compatible solution suitable for backporting to a release branch. ### Review notes It's easier to review this PR per commit: the first commit is just a revert, so it's enough to review only the second one, which is almost a one-liner. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit ee30ec7)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jan 27, 2025
Backport #7344 into `stable2412` from dmitry-markin. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #7011 and replace it with a backward-compatible solution suitable for backporting to a release branch.
Review notes
It's easier to review this PR per commit: the first commit is just a revert, so it's enough to review only the second one, which is almost a one-liner.