Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add governance and staking #253

Open
wants to merge 79 commits into
base: main
Choose a base branch
from
Open

Add governance and staking #253

wants to merge 79 commits into from

Conversation

Moliholy
Copy link
Collaborator

@Moliholy Moliholy commented Dec 11, 2024 •
edited
Loading

New pallets

This PR adds the following pallets:

Governance

  • Democracy
  • Preimage
  • Treasury
  • Scheduler

Staking

  • Collator Staking

It also removes the collator-selection pallet, as it has been replaced by collator-staking.

Fee management

This PR also:

  • Multiplies by 7 the current fees users have to pay for processing extrinsics.
  • Burns all fees instead of delivering them to either treasury or staking pots.

Moliholy and others added 30 commits May 13, 2024 17:05
@Moliholy
Add the collator staking pallet
904a1b5
@Moliholy
Rename CollatorStaking -> CollatorSelection
876fd2f
@Moliholy
Fix zombienet path
615516f
@Moliholy
Fix zombienet executable
209b2d4
@Moliholy
Fix chainspec-generator failed build
5496e70
@Moliholy
Increase kick threshold
be227d4
@Moliholy
Add testnet migration for pallet-collator-staking
45d42a4
@Moliholy
Update the collator-staking pallet
88739f8
@Moliholy
Add MaxStakers to pallet-collator-staking configuration
1d6bf87
@Moliholy
Upgrade pallet-collator-staking
a9443b3
@Moliholy
Update to the latest version
2d9f490
@Moliholy
Add runtime apis
bfa281d
@Moliholy
Merge remote-tracking branch 'origin/main' into pallet-collator-staking
99581dc
@Moliholy
Use git dependency for pallet-collator-staking
e4b7ac9
@Moliholy
Remove pallet-collator-staking from workspace
7cdd989
@Moliholy
Pin pallet-collator-staking version
7984c4d
@valentinfernandez1
Include democracy pallet on testnet
79e8f4d
@valentinfernandez1
add missing features on cargo.toml
648bbf2
@Moliholy
Polish runtime configuration for governance-related pallets
b25ea94
@Moliholy
Merge remote-tracking branch 'origin/main' into pallet-collator-staking
6e91f89
@Moliholy
Merge remote-tracking branch 'origin/main' into feat/democracy-pallet
e0ae5d2
@Moliholy
Adapt values of the democracy pallet for testnet
3b4a9e7
@Moliholy
Allow root as origin in pallet-democracy
3136b5c
@Moliholy
Add the treasury pallet to testnet runtime
8f1a525
@Moliholy
Add preimage, scheduler, democracy and treasury pallets to mainnet ru…
12c486d 
…ntime
@Moliholy
Tweak democracy and treasury parameters
b72c7b7
@Moliholy
Merge remote-tracking branch 'origin/main' into pallet-collator-staking
5c1d893
@Moliholy
Merge branch 'pallet-collator-staking' into feat/democracy-pallet
3fc2e77
@Moliholy
Send half of the fees to staking pot and half to treasury
5aa0f3f
@Moliholy
Remove collator-selection weights from testnet
0f7e0a2
@Moliholy Moliholy marked this pull request as ready for review January 3, 2025 10:27
niksaak
niksaak previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@niksaak niksaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with some open questions.

runtime/mainnet/src/migrations.rs Show resolved Hide resolved
runtime/mainnet/src/lib.rs Show resolved Hide resolved
runtime/mainnet/src/weights/pallet_balances.rs Outdated Show resolved Hide resolved
valentinfernandez1
valentinfernandez1 reviewed Jan 9, 2025
View reviewed changes
runtime/mainnet/src/lib.rs Show resolved Hide resolved
runtime/mainnet/src/lib.rs Outdated Show resolved Hide resolved
@Moliholy
Copy link
Collaborator Author

Some updates:

  • Code updated to polkadot-stable2409.
  • Muse migration removed. Muse was already migrated, and all the changes contained in the migration have already been applied.

@Moliholy
Copy link
Collaborator Author

PR updated to the latest main branch, which implies now everything is in polkadot-stable2412.

valentinfernandez1
valentinfernandez1 reviewed Jan 24, 2025
View reviewed changes
runtime/mainnet/src/lib.rs Outdated Show resolved Hide resolved
runtime/testnet/src/lib.rs Outdated Show resolved Hide resolved
@valentinfernandez1 valentinfernandez1 self-requested a review January 24, 2025 14:43
valentinfernandez1
valentinfernandez1 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@valentinfernandez1 valentinfernandez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, great work 🦾 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinfernandez1 valentinfernandez1 valentinfernandez1 approved these changes

@nbokovoy nbokovoy Awaiting requested review from nbokovoy

@niksaak niksaak Awaiting requested review from niksaak

Assignees

@Moliholy Moliholy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moliholy @niksaak @valentinfernandez1