-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Include Bitswap into request response protocols #12262
Conversation
bot merge |
Hi, sorry to comment on this after 3 months, but I also found this issue (still open) paritytech/polkadot-sdk#542 where it is said that
So, this PR means that it is no more the case? |
This didn't fix much. |
Looking at this implementation of Bitswap protocol, it would lead me to believe we can implement the protocol over the request response protocol meaning there might be some discrepancy between the "right way" and our way of implementing the codec. I'll look into how we might go about fixing this. |
Unfortunately it seems that the Bitswap protocol cannot be built on top of the request response protocol if we want to be compatible with go-ipfs and js-ipfs. There is a way for us to add support for the protocol while keeping it still as a generic protocol living above |
Include bitswap protocol into the list of enabled request response protocols. Previously the code stored the bitswap into another vector stored in
sc_network::config::Params
but didn't extend the protocol vector that contained the protocols that were given toBehaviour
, essentially leaving Bitswap disabled even if--ipfs-server
was provided on the command line.