Add remaining TODO comments

partiql · Jan 24, 2025 · 59fa4ce · 59fa4ce
1 parent ce9d4bc
commit 59fa4ce
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/internal/AccumulatorAvg.kt b/partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/internal/AccumulatorAvg.kt
@@ -59,6 +59,7 @@ internal class AccumulatorAvgDynamic : Accumulator() {
     private var count: Long = 0L
     private var accumulatorType: AccumulatorType? = null
 
+    // TODO: need to take another look at variant lowering and casing here
     override fun nextValue(value: Datum) {
         checkIsNumberType(funcName = "AVG", value = value)
         if (sum == null) {

diff --git a/partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/internal/AccumulatorSum.kt b/partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/internal/AccumulatorSum.kt
@@ -73,6 +73,8 @@ internal class AccumulatorSumDouble : Accumulator() {
 internal class AccumulatorSumDynamic : Accumulator() {
     var sum: Number? = null
     private var accumulatorType: AccumulatorType? = null
+
+    // TODO: need to take another look at variant lowering and casing here
     override fun nextValue(value: Datum) {
         checkIsNumberType(funcName = "SUM", value = value)
         // Initialize `sum` and `accumulatorType`

diff --git a/partiql-spi/src/main/kotlin/org/partiql/spi/utils/FunctionUtils.kt b/partiql-spi/src/main/kotlin/org/partiql/spi/utils/FunctionUtils.kt
@@ -83,6 +83,7 @@ internal object FunctionUtils {
             }
         }
 
+    // TODO: this should likely return the value of the datum so that if it is a variant, we don't need to lower again
     internal fun checkIsNumberType(funcName: String, value: Datum) {
         if (value.type.code() == PType.VARIANT) {
             return checkIsNumberType(funcName, value.lower())

diff --git a/partiql-spi/src/main/kotlin/org/partiql/spi/utils/NumberUtils.kt b/partiql-spi/src/main/kotlin/org/partiql/spi/utils/NumberUtils.kt
@@ -311,7 +311,7 @@ internal object NumberUtils {
         APPROX
     }
 
-    // TODO docs
+    // If types of the current sum and value are dynamic, use this function with the given `AccumulatorType`.
     fun add(curSum: Number, value: Datum, type: AccumulatorType): Number {
         return when (type) {
             AccumulatorType.INTEGRAL -> {