-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] minimization with complex arguments #71
base: main
Are you sure you want to change the base?
Conversation
Locally, with patrick-kidger/lineax#103 this fails three least square tests (two are related to some pytree structure, and one should be some complex-related bug since the wrong answer is returned) and most of the |
Unfortunately, Specifically, I see that the LU solver gets We can, of course, go the old way and merge the working stuff (minimization as for now and hopefully least squares soon) and work out the |
So the stack goes function -> jaxpr -> runtime. I think if the trace-time callstack doesn't help you, then I do have some tricks up my sleeve to help with the jaxpr and runtime approaches. To help with intercepting things at the jaxpr level then I like to use As for the runtime level then lots of |
Ok, it turns out many tests passed since I initialized the minimization at the real line. I've changed that, and now there are more fails, but that helped me to find where the problem is. |
Following up on #61 (comment)
This doesn't introduce fixes yet, just adds a simple test that fails to highlight the issue