Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix types for charts package #10274

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

jonkoops
Copy link
Contributor

Refactors the types of charts package so that they will compile when upgrading to TypeScript 5. This is needed to land #10156.

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 15, 2024

@mfrances17 mfrances17 requested review from mfrances17 and tlabaj April 15, 2024 20:10
Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... approved 👍

@tlabaj tlabaj merged commit 6d7d796 into patternfly:main Apr 22, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@7.4.0-prerelease.2
  • @patternfly/react-docs@6.4.0-prerelease.3

Thanks for your contribution! 🎉

@jonkoops jonkoops deleted the fix-types-charts branch April 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants