Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Toolbar): Fix formatting of Stacked example #11426

Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix(Toolbar): Fix formatting of Stacked example #11426

merged 2 commits into from
Jan 20, 2025

Conversation

mfrances17
Copy link
Contributor

What: Closes #11425

@mfrances17 mfrances17 requested a review from a team January 14, 2025 21:50
@mfrances17 mfrances17 self-assigned this Jan 14, 2025
@mfrances17 mfrances17 requested review from wise-king-sullyman and kmcfaul and removed request for a team January 14, 2025 21:50
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 14, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11426.surge.sh

A11y report: https://patternfly-react-pr-11426-a11y.surge.sh

thatblindgeye
thatblindgeye approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Not a blocker for here, but I feel like this example should be moved to the ## Examples sections rather than the ## Examples with toggle groups and filters section. Let me know what you think, but happy to merge as-is.

@mfrances17 mfrances17 force-pushed the toolbar-stacked-example branch from a63a72a to ad4c589 Compare January 20, 2025 15:28
@mfrances17
Copy link
Contributor Author

This looks good. Not a blocker for here, but I feel like this example should be moved to the ## Examples sections rather than the ## Examples with toggle groups and filters section. Let me know what you think, but happy to merge as-is.

Thanks... the Stacked example does use a toggle group which acts responsively when you resize the browser, so it wouldn't make sense to move to the main section above, before the concept is introduced. HOWEVER, if you were talking about the Background color variants section that follows it, I agree completely and moved it to the main section above.

@wise-king-sullyman wise-king-sullyman merged commit ffc6d88 into patternfly:main Jan 20, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.2.0-prerelease.7
  • @patternfly/react-core@6.2.0-prerelease.6
  • @patternfly/react-docs@7.2.0-prerelease.14
  • @patternfly/react-drag-drop@6.2.0-prerelease.7
  • demo-app-ts@6.0.0-prerelease.55
  • @patternfly/react-table@6.2.0-prerelease.7
  • @patternfly/react-templates@6.2.0-prerelease.7

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul kmcfaul was automatically assigned from patternfly/react-reviewers

Assignees

@mfrances17 mfrances17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Toolbar - Stacked example not displaying correctly
4 participants
@mfrances17 @patternfly-build @wise-king-sullyman @thatblindgeye