small_vector CTAD / eliminate transfer_from_same() #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity CID1569248 is under the impression that the transfer_from_same() function could throw if the variant was storing a type with index other than the function's Index template argument. The two being the same was, however, a precondition of the function. Since the two versions of transfer_from_same() was called only once each, I think that inlining them in the location that the precondition is established makes more sense than having them as separate functions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 95.56% 95.58% +0.01%
==========================================
Files 35 35
Lines 6431 6426 -5
==========================================
- Hits 6146 6142 -4
+ Misses 285 284 -1 ☔ View full report in Codecov by Sentry. |
|
paulhuggett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple CTAD guide to
small_vector<>.Eliminate the
transfer_from_same()members.Coverity CID1569248 is under the impression that the
transfer_from_same()function could throw if the variant was storing a ype with index other than the function's Index template argument. The two being the same was, however, a precondition of calling the function.Since the two versions of
transfer_from_same()was called only once each, I think that inlining them in the location that the precondition is established makes more sense than having them as separate functions.