Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An effort to ensure that noexcept declarations are all correct. #54

Merged
merged 10 commits into from
Dec 17, 2023

Conversation

paulhuggett
Copy link
Owner

No description provided.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d20866e) 95.58% compared to head (70d33cd) 91.65%.
Report is 2 commits behind head on main.

Files Patch % Lines
include/peejay/small_vector.hpp 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   95.58%   91.65%   -3.93%     
==========================================
  Files          35       15      -20     
  Lines        6426     2540    -3886     
==========================================
- Hits         6142     2328    -3814     
+ Misses        284      212      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@paulhuggett
Copy link
Owner Author

Attention: 1 lines in your changes are missing coverage. Please review.

Note that this is not correct: the line in question is covered by (at least) the SmallVector.MoveAssignLargeToLarge test.

@paulhuggett paulhuggett marked this pull request as ready for review December 17, 2023 09:29
@paulhuggett paulhuggett merged commit 3744cad into main Dec 17, 2023
35 of 36 checks passed
@paulhuggett paulhuggett deleted the sv-noexcept branch December 17, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant