Rename 'small' and 'large' to avoid clash with a Microsoft macro. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two constants should have been named simply "small" and "large". However, Microsoft's rpcndr.h unconditionally defines a macro named "small". Since they represent the index values of the small_type and large_type containers respectively , and they're a scoped enum class, I went with the rather wordy reuse of those names instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 91.66% 91.67% +0.01%
==========================================
Files 15 15
Lines 2543 2547 +4
==========================================
+ Hits 2331 2335 +4
Misses 212 212 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two constants should have been named simply "small" and "large". However, Microsoft's rpcndr.h unconditionally defines a macro named "small".
Since they represent the index values of the small_type and large_type containers respectively , and they're a scoped enum class, I went with the rather wordy reuse of those names instead.