Fix log compression bug when no logs specified #542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #541.
Regex patterns for finding log files previously broke when no log files were specified, as done for CICE5. Instead of matching no files, the
get_log_files()
method would match every file in the model work directory.This PR adds checks at the start of the
get_log_files()
andcompress_log_files()
methods, causing them to exit early when no log files are specified, and when no log files are found.It also adds a unit test
test_log_compression_no_logs()
totest_cice.py
which makes sure that the compression method does nothing when no log files are specified.With these changes, OM2 runs without any issues.