ENH: implement flutter detection #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
May 13, 2024
| @@ -17,7 +17,7 @@ | |||
| <CombineIds>false</CombineIds> | |||
| <Company>SLAC</Company> | |||
| <Released>false</Released> | |||
| <Title>LCLS General</Title> | |||
| <Title>LCLS General-nrw</Title> | |||
There was a problem hiding this comment.
Need to switch back before merge
There was a problem hiding this comment.
switched back to original project name.
nrwslac
commented
May 13, 2024
|
|
||
| nCycleTime := _TaskInfo[GETCURTASKINDEXEX()].CycleTime; | ||
| nCycleTime := nCycleTime / 10000; //convert to ms | ||
| nCalcCycleTime := UDINT_TO_TIME(nCycleTime * 4); |
There was a problem hiding this comment.
I think I missed setting this magic 4 to nNumCycles
There was a problem hiding this comment.
If the tests are really precise in what they're expecting we might get different behavior if we switch target PLCs
There was a problem hiding this comment.
replaced 4 with variable.
… properties back to original
ZLLentz
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FB_FlutterDetectionto detect a boolean changing from high to low a given amount of times within a certain time window.TestFlutterResetTestFlutterResolutionMotivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
Always Newestversion (Library, *)pre-commitor ranpre-commit run --all-files