Fix write_data() when size 0 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with RTP packets, if you receive a new network packet without payload then the relay loop is exited. This is not a good behaviour, as you can receive such packets at any time. Thus this patch fixes this permiting the write of 0 bytes inside the function. No side effects are detected, so the patch looks good.
pcherenkov
approved these changes
Dec 21, 2020
|
Hi @pcherenkov , If you agree then merge it, please! Regards. |
|
It's bundled in with the branch for REUSE PORT. Will be merged with it as
soon as you've tested.
…On Mon, Dec 21, 2020, 11:00 AM Lars The ***@***.***> wrote:
Hi @pcherenkov <https://github.com/pcherenkov> ,
If you agree then merge it, please!
Regards.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWWS2WGWOOPHGSF4P2VBTSV36B7ANCNFSM4UKRZ5WA>
.
|
|
This will be bundled in with the changes for another issue. No need for a separate merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with RTP packets, if you receive a new network packet without payload then the relay loop is exited. This is not a good behaviour, as you can receive such packets at any time. Thus this patch fixes this permiting the write of 0 bytes inside the function. No side effects are detected, so the patch looks good.