Dev sponge class #251
Dev sponge class #251
Conversation
There was a problem hiding this comment.
Hey @shaering, looks pretty good to me. I've left some notes, mostly very minor and related to commented out code. I don't mind commented out code if it is serving some purpose or might be used in the future, but this looked mostly like dead code, so I'd prefer to get rid of that. Only substantive question is about the reference solution used in heatEq.test.
Other than that, I'd like to squash most of the clean up commits (everything after 43753b3 ?) down into one to keep the history on main a bit cleaner. Any objection? If not, do you want to do that or do you prefer that I do it?
There was a problem hiding this comment.
Hey @shaering, looks pretty good to me. I've left some notes, mostly very minor and related to commented out code. I don't mind commented out code if it is serving some purpose or might be used in the future, but this looked mostly like dead code, so I'd prefer to get rid of that. Only substantive question is about the reference solution used in heatEq.test.
Other than that, I'd like to squash most of the clean up commits (everything after 43753b3 ?) down into one to keep the history on main a bit cleaner. Any objection? If not, do you want to do that or do you prefer that I do it?
|
squash away... |
Ok, I can do that once it is ready to merge. So, go ahead with the clean up changes. Once you're done with those I'll squash before merging to |
This commit includes many small style and hygiene fixes as well as build and dist fixes that are necessary prior to merging the sponge capability.
This commit includes many small style and hygiene fixes as well as build and dist fixes that are necessary prior to merging the sponge capability.
refactor of sponge into a new class. multiplier applied via pointer construction of diffusivities for operators. Example input section for three combined types of sponge zones:
[spongeMultiplier]
uniform = true
uniformMult = 100.0
plane = true
planeMult = 200.0
planeNormal = '0.0 1.0 0.0'
planePoint = '0.0 0.4 0.0'
planeWidth = 0.15
cylinder = true
cylinderMult = 200.0
cylinderRadiusY = 0.1
cylinderPoint = '0.0 0.0 0.0'
cylinderWidth = 0.1