Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORK_INPUT/OUTPUT_OPTIONS are supposed to be dicts #39

Merged
merged 1 commit into from
Sep 12, 2024
Merged

STORK_INPUT/OUTPUT_OPTIONS are supposed to be dicts #39

merged 1 commit into from
Sep 12, 2024

Conversation

olivluca
Copy link
Contributor

@olivluca olivluca commented Sep 11, 2024

I found the documentation of STORK_INPUT_OPTIONS / STORK_OUTPUT_OPTIONS confusing, so I changed it so that the example options can be directly pasted into a Pelican settings file.

@justinmayer justinmayer changed the title STORK_INPUT/OUTPUT_OPTIONS are supposed to be dicts STORK_INPUT/OUTPUT_OPTIONS are supposed to be dicts Sep 11, 2024
@justinmayer
Copy link
Contributor

Thank you for the submission, Luca.

@lioman: Given that you added these options via #5, do you have any comments/feedback on this documentation change?

@lioman
Copy link
Contributor

lioman commented Sep 11, 2024

I'll have a look tomorrow.

@lioman
Copy link
Contributor

lioman commented Sep 12, 2024

@justinmayer @olivluca That actually looks better, and I wonder why I haven't put it that way in the first place.

Copy link
Contributor

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation enhancement, @luca! 🥇

@justinmayer justinmayer merged commit cef2029 into pelican-plugins:main Sep 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants