overwrite deriveMemo param before condition

pendulum-chain · Dec 16, 2024 · 9a4c397 · 9a4c397
1 parent 779ec3d
commit 9a4c397
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/signer-service/src/api/middlewares/auth.js b/signer-service/src/api/middlewares/auth.js
@@ -2,8 +2,9 @@ const { validateSignatureAndGetMemo } = require('../services/siwe.service');
 
 const getMemoFromCookiesMiddleware = async (req, res, next) => {
   // If the client didn't specify, we don't want to pass a derived memo even if a cookie was sent.
+
+  req.derivedMemo = null; // Explicit overwrite to avoid tampering, defensive.
   if (!Boolean(req.body.memo)) {
-    req.derivedMemo = null;
     return next();
   }
   try {
@@ -52,7 +53,6 @@ const getMemoFromCookiesMiddleware = async (req, res, next) => {
     }
 
     req.derivedMemo = resultMemo;
-    console.log('derived memo', req.derivedMemo);
 
     next();
   } catch (err) {