Fix offramp process getting stuck after entering details on anchor page #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gianfra-t
approved these changes
Dec 18, 2024
Sharqiewicz
requested changes
Dec 18, 2024
Sharqiewicz
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it happens that the offramping flow is stuck after returning from the anchor page but before completing the 'prepareTransactions' phase. We suspect that this mostly happens when the Stellar horizon servers are busy and the
horizon.loadAccount()function never times out.This PR wraps the
loadAccount()function with a timeout and retry logic. For now, it's enough to only have that logic for theloadAccount()function as the implementation for transaction submissions defines a default timeout of 60 seconds and we don't need to worry about that.