Fix restoring offramp after a refresh #337
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/hooks/offramp/useMainProcess.ts
Outdated
| setOnSelectedNetworkChange(resetOfframpingState); | ||
| }, [setOnSelectedNetworkChange, resetOfframpingState]); | ||
| // useEffect(() => { | ||
| // setOnSelectedNetworkChange(resetOfframpingState); |
There was a problem hiding this comment.
I do not know why the act of passing this function triggers it, even though there is no network change.
| @@ -129,10 +129,6 @@ export const useMainProcess = () => { | |||
| setSigningPhase, | |||
| ]); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
As per the previous comment, just setting setOnSelectedNetworkChange(resetOfframpingState); causes it to trigger on mount, which removes a potential state that must be picked up for continuation.
Since the network selector is disabled during the off-ramp, I think we can remove this now.
If we still want to add it back in the future, a potential solution exists in this WIP PR, possible after merging this.
src/hooks/offramp/useMainProcess.ts
Outdated
| @@ -183,7 +180,16 @@ export const useMainProcess = () => { | |||
| // but we intentionally exclude them from the dependency array to prevent unnecessary re-renders. | |||
There was a problem hiding this comment.
nit: We can remove this comment if nothing is missing from the dependency array
Solves issue: Stuck after anchor completion.