Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Update Mobile styles #384

Merged
merged 12 commits into from
Jan 20, 2025
Merged

[READY] Update Mobile styles #384

merged 12 commits into from
Jan 20, 2025

Conversation

Sharqiewicz
Copy link
Contributor

@Sharqiewicz Sharqiewicz commented Jan 16, 2025 •
edited
Loading

PR 🦈🟢

  • remove Vortex logo from Navbar
  • update UserBalance icon
  • unify the height of the buttons on the Navbar
  • adjust font-size for FeeCollapse (to fit correctly after the form resize to 384px)
  • add slight animations for sell crypto form and trusted by section
  • move Payments to PoweredBy section
  • add Powered by Vortex

Close: #381

@Sharqiewicz Sharqiewicz linked an issue Jan 16, 2025 that may be closed by this pull request
Add new icons to the form element and make change to the Navbar #381
Closed
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 4fd8653
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/678e59bb8a4e7a000861ff60
😎 Deploy Preview https://deploy-preview-384--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz Sharqiewicz changed the title [DRAFT] Update Mobile styles Update Mobile styles Jan 16, 2025
@Sharqiewicz Sharqiewicz marked this pull request as ready for review January 16, 2025 19:11
@Sharqiewicz Sharqiewicz requested a review from a team January 16, 2025 19:15
@Sharqiewicz Sharqiewicz changed the title Update Mobile styles [READY] Update Mobile styles Jan 16, 2025
ebma
ebma reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@ebma ebma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. The animations are lovely 👌 Some remarks:

  • It seems like in the nav bar, the margin left of the 'Sell Crypto' is not equal to the right margin of the connect-wallet button. (This is because of the inner padding of the 'Sell crypto' div)
  • It should say 'A SatoshiPay company' not just 'SatoshiPay'.
  • I think the items need a bit of spacing.
image

@prayagd
Copy link
Collaborator

prayagd commented Jan 20, 2025

LGTM to same comments as Marcel, one other small thing
Can we change the helper text of Lower fees section to "Offramping fees as low as 0.25%." See reference
Screenshot 2025-01-20 at 2 39 47 PM

ebma
ebma approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@Sharqiewicz Sharqiewicz merged commit bac09dd into polygon-prototype-staging Jan 20, 2025
5 checks passed
@ebma ebma deleted the 381-add-new-icons-to-the-form-element-and-make-change-to-the-navbar branch January 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new icons to the form element and make change to the Navbar
3 participants
@Sharqiewicz @prayagd @ebma