refactor: define an ember-core eslint config for ember-app and ember-…

…addon configs
peopledoc · Feb 18, 2021 · 2fc93ac · 2fc93ac
1 parent 46ca036
commit 2fc93ac
Show file tree

Hide file tree

Showing 3 changed files with 62 additions and 69 deletions.
diff --git a/ember-addon.js b/ember-addon.js
@@ -1,40 +1,13 @@
 module.exports = {
-  parser: "babel-eslint",
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: "module",
-    ecmaFeatures: {
-      legacyDecorators: true
-    }
-  },
-  plugins: [
-    "ember",
-    "ember-suave"
-  ],
   extends: [
-    "eslint:recommended",
-    "plugin:ember/recommended",
-    "plugin:ember-suave/recommended",
-    "./core.js"
+    "./ember-core.js"
   ],
-  env: {
-    browser: true
-  },
-  rules: {
-    "ember/no-jquery": "warn",
-    "ember-suave/require-access-in-comments": "off"
-  },
   overrides: [
     // node files
     {
       files: [
-        ".eslintrc.js",
-        ".template-lintrc.js",
-        "ember-cli-build.js",
         "index.js",
-        "testem.js",
         "blueprints/*/index.js",
-        "config/**/*.js",
         "tests/dummy/config/**/*.js"
       ],
       excludedFiles: [
@@ -57,13 +30,6 @@ module.exports = {
         // https://github.com/mysticatea/eslint-plugin-node/issues/77
         'node/no-unpublished-require': 'off'
       }
-    },
-    // testem config file
-    {
-      files: ["testem.js"],
-      rules: {
-        camelcase: "off"
-      }
     }
   ]
 }
diff --git a/ember-core.js b/ember-core.js
@@ -0,0 +1,60 @@
+module.exports = {
+  parser: "babel-eslint",
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: "module",
+    ecmaFeatures: {
+      legacyDecorators: true
+    }
+  },
+  plugins: [
+    "ember",
+    "ember-suave"
+  ],
+  extends: [
+    "eslint:recommended",
+    "plugin:ember/recommended",
+    "plugin:ember-suave/recommended",
+    "./core.js"
+  ],
+  env: {
+    browser: true
+  },
+  rules: {
+    "ember/no-jquery": "warn",
+    "ember-suave/require-access-in-comments": "off"
+  },
+  overrides: [
+    // node files
+    {
+      files: [
+        ".eslintrc.js",
+        ".template-lintrc.js",
+        "ember-cli-build.js",
+        "testem.js",
+        "config/**/*.js"
+      ],
+      parserOptions: {
+        sourceType: "script"
+      },
+      env: {
+        browser: false,
+        node: true
+      },
+      plugins: ["node"],
+      extends: ['plugin:node/recommended'],
+      rules: {
+        // this can be removed once the following is fixed
+        // https://github.com/mysticatea/eslint-plugin-node/issues/77
+        'node/no-unpublished-require': 'off'
+      }
+    },
+    // testem config file
+    {
+      files: ["testem.js"],
+      rules: {
+        camelcase: "off"
+      }
+    }
+  ]
+}
diff --git a/ember.js b/ember.js
@@ -1,37 +1,11 @@
 module.exports = {
-  parser: "babel-eslint",
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: "module",
-    ecmaFeatures: {
-      legacyDecorators: true
-    }
-  },
-  plugins: [
-    "ember",
-    "ember-suave"
-  ],
   extends: [
-    "eslint:recommended",
-    "plugin:ember/recommended",
-    "plugin:ember-suave/recommended",
-    "./core.js"
+    "./ember-core.js"
   ],
-  env: {
-    browser: true
-  },
-  rules: {
-    "ember/no-jquery": "warn",
-    "ember-suave/require-access-in-comments": "off"
-  },
   overrides: [
     // node files
     {
       files: [
-        ".eslintrc.js",
-        ".template-lintrc.js",
-        "ember-cli-build.js",
-        "testem.js",
         "config/**/*.js",
         "lib/*/index.js",
         "server/**/*.js"
@@ -50,13 +24,6 @@ module.exports = {
         // https://github.com/mysticatea/eslint-plugin-node/issues/77
         'node/no-unpublished-require': 'off'
       }
-    },
-    // testem config file
-    {
-      files: ["testem.js"],
-      rules: {
-        camelcase: "off"
-      }
     }
   ]
 }