Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mykrobe #99

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix Mykrobe #99

merged 3 commits into from
Jan 7, 2025

Conversation

zwets
Copy link
Contributor

@zwets zwets commented Jan 4, 2025

One last small PR on the hAMRonization project: make Mykrobe not choke on an empty JSON object ('{ }').

With this fix applied we can re-enable Mykrobe in the workflow. Even if it supports only three species ... nice to have it on board.

I have bumped the version in __init__.py to 1.1.9, so the workflow can set a proper dependency (though it still points at the repo code now).

@fmaguire fmaguire merged commit 7521fb3 into pha4ge:master Jan 7, 2025
2 checks passed
@fmaguire
Copy link
Member

fmaguire commented Jan 7, 2025

@zwets incredible work! thanks so much for all your contributions

@zwets zwets deleted the fix-mykrobe branch January 8, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants