Skip to content

Commit

Permalink
Remove unresolvable names from buildreq_cache
Browse files Browse the repository at this point in the history
The buildreq cache should only contain names/symbols/etc that are
resolvable at build time. The names may indicate missing packages, but
they may also be invalid, so it is best to avoid adding the names to the
cache in the first place.

Fixes clearlinux#480

Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
  • Loading branch information
phmccarty committed Jan 11, 2020
1 parent 7eb5926 commit 182dc05
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion autospec/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ def parse_buildroot_log(filename, returncode):
for line in loglines:
match = missing_pat.match(line)
if match is not None:
util.print_fatal("Cannot resolve dependency name: {}".format(match.group(1)))
name = match.group(1)
util.print_fatal("Cannot resolve dependency name: {}".format(name))
# Avoid adding the dependency name to the buildreq cache
buildreq.remove_buildreq(name)
is_clean = False

return is_clean
Expand Down

0 comments on commit 182dc05

Please sign in to comment.