Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SMP on GR712RC #473

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Enable SMP on GR712RC #473

merged 3 commits into from
Nov 16, 2023

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented Nov 8, 2023 •
edited
Loading

Description

This PR:

  • extracts common TLB interface in HAL and adapts ia32 port to work with the changes
  • enables SMP on GR712RC

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@lukileczo lukileczo force-pushed the lukileczo/smp-gr712 branch from d6f5fc7 to 4d00d6b Compare November 8, 2023 10:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

Unit Test Results

5 989 tests  ±0   5 348 ✔️ ±0   30m 13s ⏱️ + 1m 0s
   333 suites ±0      641 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit 2ad291b. ± Comparison against base commit 6d4fdf2.

♻️ This comment has been updated with latest results.

@lukileczo lukileczo force-pushed the lukileczo/smp-gr712 branch 5 times, most recently from 40f3bab to c40529c Compare November 15, 2023 11:07
@lukileczo lukileczo marked this pull request as ready for review November 15, 2023 16:09
@lukileczo lukileczo requested a review from agkaminski November 15, 2023 16:09
agkaminski
agkaminski reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small doubt on my part, otherwise LGTM. I like the TLB code refactor very much

hal/sparcv8leon3/gaisler/gr712rc/_init.S Show resolved Hide resolved
agkaminski
agkaminski approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hal/sparcv8leon3/gaisler/gr712rc/_init.S Show resolved Hide resolved
@lukileczo lukileczo merged commit 5f3dd1e into master Nov 16, 2023
30 checks passed
@lukileczo lukileczo deleted the lukileczo/smp-gr712 branch November 16, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukileczo @agkaminski