Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psh: add help command test #159

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

damianloew
Copy link
Contributor

@damianloew damianloew commented Jan 2, 2023

Description

psh: add help command test

Motivation and Context

JIRA: PD-77

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@damianloew damianloew force-pushed the damianloew/psh_help_test branch from 9378684 to 20a8a37 Compare January 2, 2023 14:31
@damianloew damianloew marked this pull request as ready for review January 2, 2023 15:12
psh/test-help.py Outdated Show resolved Hide resolved
psh/test.yaml Outdated Show resolved Hide resolved
@damianloew damianloew force-pushed the damianloew/psh_help_test branch from 20a8a37 to 84fa0b6 Compare January 3, 2023 12:50
@damianloew damianloew requested a review from xvuko January 3, 2023 12:51
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-structured and should serve its purpose efficiently

However, I'm wondering if it's the intended effect that, regardless of the argument given to the help function, it's always displayed? If so, I don't see any other test cases, except maybe a test could be added to check, for example, if the function displayed "Unknown command!" with HELP written in uppercase."

@damianloew damianloew force-pushed the damianloew/psh_help_test branch from 84fa0b6 to 4d5ed29 Compare November 2, 2023 13:46
Copy link

github-actions bot commented Nov 2, 2023

Unit Test Results

5 957 tests  +8   5 304 ✔️ +8   30m 32s ⏱️ - 2m 0s
   333 suites +8      653 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 4d5ed29. ± Comparison against base commit a37c915.

@mateusz-bloch mateusz-bloch merged commit 62dbbc2 into master Nov 7, 2023
33 checks passed
@mateusz-bloch mateusz-bloch deleted the damianloew/psh_help_test branch November 7, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants