-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maska989/ping_test #254
base: master
Are you sure you want to change the base?
Maska989/ping_test #254
Conversation
7e2369c
to
b5fd34f
Compare
Unit Test Results5 681 tests - 1 779 5 142 ✅ - 1 602 28m 25s ⏱️ - 10m 15s For more details on these failures, see this check. Results for commit 0981721. ± Comparison against base commit 04b1486. This pull request removes 1780 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the test looks good.
Do we know if pinging domain names works, and is there an intention to support it?
What happen if we ping broadcast address?
b5fd34f
to
9aee81f
Compare
20ff96e
to
4bb41a8
Compare
Generic remarks:
|
TWM for writing about generic remarks, all of this needs rethink about test structure and runner options.
Rn I'm using this PR to research/configure Ethernet support on Again, thanks 4 all your help. |
4bb41a8
to
16017af
Compare
IMHO using
|
4d581c8
to
6535925
Compare
072f28a
to
2e9f237
Compare
6de577e
to
7e1eb07
Compare
7e1eb07
to
9e47669
Compare
Right now this PR waiting for ifconfig and route implementation. |
9e47669
to
02151d0
Compare
cc57492
to
7163e55
Compare
5b3ecaf
to
8724481
Compare
44aeddc
to
b420c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several morelike cosmetic improvements, you don't have to apply them if you don't want to
b420c60
to
cd1494b
Compare
d75cf35
to
2dc6ef3
Compare
port: Optional[str] = "/dev/ttyUSB0", | ||
host_ip: Optional[str] = "10.0.0.1", | ||
target_ip: Optional[str] = "10.0.0.2", | ||
interface_idle_time: Optional[int] = "10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter is declared as an Optional[int] but has a default value of type str
interface_idle_time: Optional[int] = "10", | |
interface_idle_time: Optional[int] = 10, |
time.sleep(0.01) | ||
asleep += 0.01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inefficient timeout ? Is it worth invoking ifconfig every 0.01 second?
host_setup = inet + netmask | ||
return host_setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, but do whatever you think is more readable
host_setup = inet + netmask | |
return host_setup | |
return inet + netmask |
IP_LOOPBACK = "127.0.0.1" | ||
|
||
|
||
def ping_output_regex(target, iteration, possible_fail: Optional[bool] = False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Optional
needed ?
JIRA: CI-326
2dc6ef3
to
0981721
Compare
Description
JIRA: CI-326
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
_project: setup targets for PPP and LwiP usage phoenix-rtos-project#1021
psh: implement
route
management tool phoenix-rtos-utils#207