Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: assert jffs2 via output instead of time #283

Merged
merged 2 commits into from
Nov 7, 2023
Merged

trunner: assert jffs2 via output instead of time #283

merged 2 commits into from
Nov 7, 2023

Conversation

maska989
Copy link
Contributor

Description

Changed approach how are determined problems with erase with jffs2.

Motivation and Context

JIRA: CI-375

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a9-zynq7000-zedboard.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@maska989 maska989 marked this pull request as draft October 25, 2023 09:06
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Unit Test Results

5 949 tests  ±0   5 308 ✔️ ±0   29m 12s ⏱️ - 2m 22s
   325 suites ±0      641 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit 063e64a. ± Comparison against base commit 099b34e.

♻️ This comment has been updated with latest results.

@maska989 maska989 force-pushed the maska989/jffs2_echo_assert branch from c8b6b82 to 290f7d2 Compare October 25, 2023 12:02
@maska989 maska989 marked this pull request as ready for review October 25, 2023 13:06
@maska989 maska989 requested a review from damianloew October 25, 2023 13:06
damianloew
damianloew requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions left

trunner/target/armv7a9.py Show resolved Hide resolved
trunner/harness/plo.py Outdated Show resolved Hide resolved
trunner/harness/plo.py Outdated Show resolved Hide resolved
trunner/harness/plo.py Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Oct 27, 2023
View reviewed changes
trunner/harness/plo.py Outdated Show resolved Hide resolved
trunner/harness/plo.py Outdated Show resolved Hide resolved
@damianloew damianloew mentioned this pull request Oct 27, 2023
Closed
13 tasks
@maska989 maska989 marked this pull request as draft October 27, 2023 10:36
@maska989 maska989 force-pushed the maska989/jffs2_echo_assert branch from 1aa9091 to 545bacb Compare October 30, 2023 13:01
@maska989 maska989 marked this pull request as ready for review October 30, 2023 14:51
damianloew
damianloew requested changes Nov 2, 2023
View reviewed changes
trunner/harness/plo.py Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/jffs2_echo_assert branch 2 times, most recently from 4e97ba3 to ab0a908 Compare November 6, 2023 10:35
damianloew
damianloew requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd create the separate commit for applying black corrections in test_runner.py, so for example:

trunner: apply black corrections in test_runner.py

@maska989 maska989 force-pushed the maska989/jffs2_echo_assert branch from ab0a908 to 063e64a Compare November 6, 2023 12:51
@maska989 maska989 requested a review from damianloew November 6, 2023 12:52
damianloew
damianloew approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianloew damianloew merged commit f7ad295 into master Nov 7, 2023
33 checks passed
@damianloew damianloew deleted the maska989/jffs2_echo_assert branch November 7, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

@nalajcie nalajcie Awaiting requested review from nalajcie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maska989 @nalajcie @damianloew