libc: add passing custom parameter to unix-socket test #378

adamdebek · 2024-10-07T12:26:25Z

…et test

JIRA: CI-501

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

github-actions · 2024-10-07T12:41:05Z

Unit Test Results

7 787 tests ±0 7 069 ✅ ±0 40m 55s ⏱️ - 1m 52s
461 suites ±0 718 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit cca6f20. ± Comparison against base commit 7e3f9f2.

♻️ This comment has been updated with latest results.

nalajcie · 2024-10-07T13:34:19Z

maybe it would be better to pass custom timeout param as a commandline param if possible (that way we will be able to provide custom values for any particular target requiring it?)

mateusz-bloch · 2024-10-08T11:02:52Z

nit: Commit title should be short, details can be described in the commit message body

nalajcie

some nitpicks, also 👍 for writing short/simple commit message titles

libc/socket/unix-socket.c

nalajcie · 2024-10-09T10:45:13Z

libc/socket/unix-socket.c

+	if (argc == 2) {
+		pollTimeoutDiff = atoi(argv[1]);
+	}
+
 	/* Assume /tmp dir is missing */


is this comment valid? the code looks like we assume initially that it's not missing? Also fix check if (isMissing) to be MISRA-compliant (or use bool)

The suggestion hasn't been fully taken into account. Still the comment seems to be wrong. I'd remove the comment and rename the variable name to make readable what is happening in here (createTmpIfMissing doesn't check the arg, it check's whether dir exists anyway and then sets the value).

libc/socket/unix-socket.c

nalajcie · 2024-10-09T14:51:22Z

libc/socket/unix-socket.c

adamgreloch · 2024-10-09T15:32:17Z

libc/socket/unix-socket.c

+	 */
+	for (int i = 1; i < argc; i++) {
+		if (strcmp(argv[i], "--extra-poll-delay-ms") == 0) {
+			pollTimeoutDelay = atoi(argv[i + 1]);


Should pollTimeoutDelay ever be allowed to have negative value? If not, maybe it'd be good to have a simple argument value validation here?

It is passed directly in test.yaml, but I can add it.

damianloew

Please look at the latest comments and then we can merge it :)

damianloew · 2024-10-29T09:06:09Z

libc/socket/unix-socket.c

 	/* Assume /tmp dir is missing */
 	int isMissing = 0;


Suggested change

/* Assume /tmp dir is missing */

int isMissing = 0;

bool wasTmpMissing = false;

Please see the comment above.

damianloew · 2024-10-29T09:08:41Z

libc/socket/unix-socket.c

+	if (argc == 2) {
+		pollTimeoutDiff = atoi(argv[1]);
+	}
+
 	/* Assume /tmp dir is missing */


The suggestion hasn't been fully taken into account. Still the comment seems to be wrong. I'd remove the comment and rename the variable name to make readable what is happening in here (createTmpIfMissing doesn't check the arg, it check's whether dir exists anyway and then sets the value).

Add passing custom parameter to unix-socket test on armv7a9-zynq7000-qemu since blocking interval significantly overruns timeout due to host system scheduling delays JIRA: CI-501

adamdebek requested a review from damianloew October 7, 2024 12:48

adamdebek force-pushed the adamdebek/CI-501 branch 3 times, most recently from 371e861 to 887953c Compare October 7, 2024 15:00

adamdebek mentioned this pull request Oct 7, 2024

add EMULATED define to CPPFLAGS for emulated targets phoenix-rtos/phoenix-rtos-build#209

Closed

14 tasks

adamdebek force-pushed the adamdebek/CI-501 branch from 887953c to 32b45b7 Compare October 8, 2024 11:07

nalajcie reviewed Oct 9, 2024

View reviewed changes

adamdebek force-pushed the adamdebek/CI-501 branch 2 times, most recently from e5f5080 to ddbba9b Compare October 9, 2024 11:49

adamdebek changed the title ~~libc: add custom timeout discrepancy for emulated target in unix-sock…~~ libc: add passing custom parameter to unix-socket test Oct 9, 2024

adamdebek requested a review from nalajcie October 9, 2024 12:12

adamdebek force-pushed the adamdebek/CI-501 branch from ddbba9b to fa0f338 Compare October 9, 2024 12:58

nalajcie reviewed Oct 9, 2024

View reviewed changes

libc/socket/unix-socket.c Outdated Show resolved Hide resolved

adamdebek force-pushed the adamdebek/CI-501 branch from fa0f338 to e5a3e81 Compare October 9, 2024 13:14

nalajcie requested a review from adamgreloch October 9, 2024 14:50

adamgreloch reviewed Oct 9, 2024

View reviewed changes

libc/socket/unix-socket.c Show resolved Hide resolved

adamdebek force-pushed the adamdebek/CI-501 branch 2 times, most recently from 8790843 to 12e5c5e Compare October 9, 2024 15:19

adamgreloch reviewed Oct 9, 2024

View reviewed changes

adamdebek force-pushed the adamdebek/CI-501 branch 2 times, most recently from bae5e5a to 7128227 Compare October 10, 2024 11:01

adamdebek requested a review from nalajcie October 10, 2024 12:11

adamdebek force-pushed the adamdebek/CI-501 branch from 7128227 to c18bc5f Compare October 25, 2024 14:09

damianloew reviewed Oct 29, 2024

View reviewed changes

libc: add passing custom parameter to unix-socket test

cca6f20

Add passing custom parameter to unix-socket test on armv7a9-zynq7000-qemu since blocking interval significantly overruns timeout due to host system scheduling delays JIRA: CI-501

adamdebek force-pushed the adamdebek/CI-501 branch from c18bc5f to cca6f20 Compare October 29, 2024 12:49

damianloew approved these changes Oct 29, 2024

View reviewed changes

adamdebek merged commit 1666b3b into master Oct 29, 2024
36 checks passed

adamdebek deleted the adamdebek/CI-501 branch October 29, 2024 13:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libc: add passing custom parameter to unix-socket test #378

libc: add passing custom parameter to unix-socket test #378

adamdebek commented Oct 7, 2024 •

edited by nalajcie

Loading

github-actions bot commented Oct 7, 2024 •

edited

Loading

nalajcie commented Oct 7, 2024

mateusz-bloch commented Oct 8, 2024

nalajcie left a comment

nalajcie Oct 9, 2024

damianloew Oct 29, 2024

nalajcie commented Oct 9, 2024

adamgreloch Oct 9, 2024

adamdebek Oct 9, 2024

damianloew left a comment

damianloew Oct 29, 2024

damianloew Oct 29, 2024

	/* Assume /tmp dir is missing */
	int isMissing = 0;
	bool wasTmpMissing = false;

libc: add passing custom parameter to unix-socket test #378

libc: add passing custom parameter to unix-socket test #378

Conversation

adamdebek commented Oct 7, 2024 • edited by nalajcie Loading

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

github-actions bot commented Oct 7, 2024 • edited Loading

Unit Test Results

nalajcie commented Oct 7, 2024

mateusz-bloch commented Oct 8, 2024

nalajcie left a comment

Choose a reason for hiding this comment

nalajcie Oct 9, 2024

Choose a reason for hiding this comment

damianloew Oct 29, 2024

Choose a reason for hiding this comment

nalajcie commented Oct 9, 2024

adamgreloch Oct 9, 2024

Choose a reason for hiding this comment

adamdebek Oct 9, 2024

Choose a reason for hiding this comment

damianloew left a comment

Choose a reason for hiding this comment

damianloew Oct 29, 2024

Choose a reason for hiding this comment

damianloew Oct 29, 2024

Choose a reason for hiding this comment

adamdebek commented Oct 7, 2024 •

edited by nalajcie

Loading

github-actions bot commented Oct 7, 2024 •

edited

Loading