Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alias: Add option to use relative alias offset #310

Merged
merged 1 commit into from
Dec 27, 2023
Merged

alias: Add option to use relative alias offset #310

merged 1 commit into from
Dec 27, 2023

Conversation

agkaminski
Copy link
Member

@agkaminski agkaminski commented Dec 12, 2023 •
edited
Loading

DONE: RTOS-713

Description

OPTIONAL - to be determined whether we want this or not

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (ia32-generic-qemu).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Unit Test Results

6 410 tests  +408   5 776 ✅ +408   32m 21s ⏱️ + 1m 40s
  354 suites +  8     634 💤 ±  0 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 0056e69. ± Comparison against base commit 90051dc.

♻️ This comment has been updated with latest results.

gorbanchovie
gorbanchovie reviewed Dec 12, 2023
View reviewed changes
cmds/alias.c Show resolved Hide resolved
cmds/alias.c Outdated Show resolved Hide resolved
cmds/alias.c Outdated Show resolved Hide resolved
gorbanchovie
gorbanchovie previously approved these changes Dec 13, 2023
View reviewed changes
Copy link

@gorbanchovie gorbanchovie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gerard5
gerard5 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@gerard5 gerard5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add small log improvements, see inline comments.

cmds/alias.c Outdated Show resolved Hide resolved
cmds/alias.c Show resolved Hide resolved
gorbanchovie
gorbanchovie approved these changes Dec 27, 2023
View reviewed changes
Copy link

@gorbanchovie gorbanchovie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gorbanchovie gorbanchovie merged commit 853e131 into master Dec 27, 2023
30 checks passed
@gorbanchovie gorbanchovie deleted the agkaminski/rtos-713 branch December 27, 2023 09:42
@kemonats
Copy link
Contributor

This PR has been merged but I have a minor comment, in lines 113 and 117 instead of argv[1] it should be argv[optind].

@agkaminski agkaminski mentioned this pull request Jan 8, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerard5 gerard5 gerard5 left review comments

@gorbanchovie gorbanchovie gorbanchovie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agkaminski @kemonats @gerard5 @gorbanchovie