add options attribute to inputs_for/1 #2981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoenix.HTML.FormData.to_form/4
allows for arbitrary protocol-specific options to be passed in the fourth argument.Phoenix.Component.inputs_for/1
currently only supports options specific to the protocol implementation forEcto.Changeset
. This PR adds a newoptions
attribute that can be used to pass any additional options for other implementations.Context:
Flop.Phoenix
implements theFormData
protocol for theFlop.Meta
struct and relies on afields
option to be passed. This is currently only possible with theinputs_for/4
function that was moved toPhoenixHTMLHelpers
, but not with theinputs_for
component.Relates to woylie/flop_phoenix#299.