Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: Multiple issues #5

Merged
merged 14 commits into from
Jun 14, 2024
Merged

Resolve: Multiple issues #5

merged 14 commits into from
Jun 14, 2024

Conversation

SOHELAHMED7
Copy link
Member

@SOHELAHMED7 SOHELAHMED7 commented Jun 5, 2024 •
edited
Loading

Fixes #4

Also fixes #6

Highlights:

  • dropped support for PHP versions < 8
  • CI passes with >= PHP 8
  • fixed issues when faced while initial local setup
  • upgraded dependencies and tests
  • added multi PHP versions support for local development / switching PHP versions and added docs for it
  • fixed bugs
  • added CONTRIBUTING.md

@SOHELAHMED7 SOHELAHMED7 requested a review from cebe June 5, 2024 08:50
@SOHELAHMED7 SOHELAHMED7 self-assigned this Jun 5, 2024
@SOHELAHMED7 SOHELAHMED7 mentioned this pull request Jun 5, 2024
Closed
@SOHELAHMED7 SOHELAHMED7 linked an issue Jun 5, 2024 that may be closed by this pull request
Setup the project locally and docs for it #6
Closed
@SOHELAHMED7 SOHELAHMED7 marked this pull request as ready for review June 11, 2024 15:00
@SOHELAHMED7 SOHELAHMED7 changed the title Draft: Fix CI to work with PHP 7.4 and 8.x #4 Resolve: Multiple issues Jun 11, 2024
cebe
cebe reviewed Jun 12, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
cebe
cebe reviewed Jun 12, 2024
View reviewed changes
tests/docker/xdebug.ini Outdated Show resolved Hide resolved
@SOHELAHMED7 SOHELAHMED7 merged commit bfb4774 into master Jun 14, 2024
4 checks passed
@cebe cebe deleted the 4-fix-ci-to-work-with-php-74-and-8x branch June 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebe cebe cebe approved these changes

Assignees

@SOHELAHMED7 SOHELAHMED7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup the project locally and docs for it Fix CI to work with PHP 7.4 and 8.x
2 participants
@SOHELAHMED7 @cebe