Documentation updates #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
============================================
- Coverage 91.70% 91.48% -0.22%
- Complexity 250 251 +1
============================================
Files 4 4
Lines 615 658 +43
============================================
+ Hits 564 602 +38
- Misses 51 56 +5 |
JoolsMcFly
force-pushed
the
chore/update-documentation
branch
from
a7f35b3 to
a1486cc
Compare
|
🤔 why am I getting these coverage issues? I've only changed an md file. |
MauricioFauth
approved these changes
Oct 11, 2024
Signed-off-by: Julien Dephix <jdephix@hotmail.com>
JoolsMcFly
force-pushed
the
chore/update-documentation
branch
from
a1486cc to
7e59040
Compare
|
Hi. Is there anything I can do to get this merged? Thanks! |
|
Merged! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
Now that we're using enums
$shp = new \PhpMyAdmin\ShapeFile\ShapeFile(0);is not valid anymore so documentation needs an update. This is what this PR does (along with some rewording).Thansk for rewiewing.
ps: I'll squash and sign when it's ready to be merged. 👍