Slight performance improvement, avoid useless costy calls to getAttri…

…bute Signed-off-by: William Desportes <williamdes@wdes.fr>
phpmyadmin · Feb 24, 2021 · 283673f · 283673f
1 parent e76c70b
commit 283673f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Node/TransNode.php b/src/Node/TransNode.php
@@ -159,15 +159,16 @@ public function compile(Compiler $compiler)
             $compiler->raw('), array(');
 
             foreach ($vars as $var) {
-                if ($var->getAttribute('name') === 'count') {
+                $attributeName = $var->getAttribute('name');
+                if ($attributeName === 'count') {
                     $compiler
                         ->string('%count%')
                         ->raw(' => abs(')
                         ->subcompile($this->getNode('count'))
                         ->raw('), ');
                 } else {
                     $compiler
-                        ->string('%' . $var->getAttribute('name') . '%')
+                        ->string('%' . $attributeName . '%')
                         ->raw(' => ')
                         ->subcompile($var)
                         ->raw(', ');
@@ -233,8 +234,9 @@ protected function compileString(Node $body): array
                     while ($n instanceof CheckToStringNode) {
                         $n = $n->getNode('expr');
                     }
-                    $msg .= sprintf('%%%s%%', $n->getAttribute('name'));
-                    $vars[] = new NameExpression($n->getAttribute('name'), $n->getTemplateLine());
+                    $attributeName = $n->getAttribute('name');
+                    $msg .= sprintf('%%%s%%', $attributeName);
+                    $vars[] = new NameExpression($attributeName, $n->getTemplateLine());
                 } else {
                     $msg .= $node->getAttribute('data');
                 }