Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid "Undefined variable $unicode" warnings #3189

Closed
wants to merge 1 commit into from

Conversation

costing
Copy link

@costing costing commented Jan 2, 2025

In the original form I was getting warnings like

<b>Warning</b>:  Undefined variable $unicode in <b>/var/www/html/admin/scripts/pi-hole/php/func.php</b> on line <b>687</b><br />

printed in the HTML output of /scripts/pi-hole/php/groups.php, which was not a valid JSON any more and led to an error displaying the blacklisted domains.

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

In the original form I was getting warnings like 
```
<b>Warning</b>:  Undefined variable $unicode in <b>/var/www/html/admin/scripts/pi-hole/php/func.php</b> on line <b>687</b><br />
```
printed in the HTML output of `/scripts/pi-hole/php/groups.php`, which was not a valid JSON any more and led to an error displaying the blacklisted domains.

Signed-off-by: Costin Grigoras <costing@gmail.com>
@yubiuser
Copy link
Member

yubiuser commented Jan 2, 2025

Thanks for your PR. Please note, all PRs should be based on and target development branch.
The current code in development actually removed all PHP, so this change is not needed anymore.

@yubiuser yubiuser closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants