Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak bar colors used by "Total queries" graphic #3198

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Jan 24, 2025

What does this PR aim to accomplish?

Pi-hole v5 had only 2 categories to show: Blocked queries and Forwarded queries (allowed).

Now, Pi-hole v6 has 4 categories: Forwarded, Cached, Blocked and Other, but in some themes, the colors used for each category were very hard to distinguish between each other.

Example - Forwarded and cached were indistinguishable:

Forwarded and cached were almost indistinguishable

How does this PR accomplish the above?

Use more distinct colors and try to always use the same colors (Green for Forwarded, Red for Blocked, Blue for Cached - Other will use gray or any other color).

bar_colors

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Use CSS properties to define initial colors for the graphic bars in the dashboard
- Allowed (green);
- Blocked (red);
- Cached (blue);
- Total queries (gray).

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the tweak/graph_bar_colors branch from bd7c4bf to 2d68446 Compare January 24, 2025 20:40
@rdwebdesign rdwebdesign requested a review from a team January 24, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant