-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate global and regional mif #205
Conversation
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the calcHistorical for all data but the data for which we do not have meaningful regional data. For those I would use your new calcHistoricalGlobal. But I would not calculate an additional file containing the regional data. They are anyway meaningless. Otherwise we could keep/add them in the default calcHistorical
@LaviniaBaumstark If I understand you correctly, you don't see the need for calcHistoricalRegion. Right now, I am not sure how to avoid using three files. Using the example of IEA_ETP data, if I moved it back into calcHistorical, we would get duplicate data in historical.mif and historical_global.mif, i.e. the IEA ETP data for region GLO would be in both files. When merging the mifs to run compareScenarios, you would have to take care of such duplicates. If I have to write logic to filter out data from the combined mifs later on, we are almost back to where we are right now (the improvement being that you might be able to apply more general rules to filter data at least instead of model specific filtering rules as we have to do right now) Btw, I can think of cases where the two files will have global data for the same model and the data would differ. Then you have to write a rule: if the global file has data for that model+region, ignore the global data for model+region in the general historical.mif. |
It would "solve" the problem alright, but that is solved already. The root cause is Regarding this merge request, I'm more opposed than in favour. It does |
After talking again to Lavinia, we found a solution that does not require more than one historical.mif while filtering the regional data we do not want to include using the append attribute of calcOutput. This implementation is more in line with the magclass counterpart . |
d4ff0e3
to
0ffd01d
Compare
Following a discussion with @LaviniaBaumstark , we are suggesting the following solution to issue #194
From now on, we create 3 historical.mif files: in addition to the one with any regional resolution, we also have on with only regional resolution and one with only global resolution. These have to be stitched together again in remind2 compareScenarios.
Use cases demonstrated in this PR:
@LaviniaBaumstark Is this implementation what you had in mind?
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Do you think this is a feasible solution for your problem with IEA ETP data? Advantage over filtering in remind2 is that we define in one central place which regional data we do not want to export instead of doing it in all the places where the mif files are read in. Disadvantage is that we need to read in three files now.