Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter historic datawith low accuracy or faulty aggregation in compareScenarios2() #173

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

Did I read the intention of

# remove regional and global data from WEO 2021 source due to lack of accuracy
if (any(grepl("IEA WEO 2021", getNames(histData)))) {
histData.WEO <- histData[,,"IEA WEO 2021", pmatch = T]
histData.WEO[histData.WEO == 0] <- NA
histData.WEO[setdiff(getRegions(histData.WEO), "GLO"), ,
c("IEA WEO 2021 APS GLO", "IEA WEO 2021 Net2050 GLO", "IEA WEO 2021 SDS GLO", "IEA WEO 2021 SPS GLO"),
pmatch = T
] <- NA
histData.WEO["GLO", ,
c("IEA WEO 2021 APS regional", "IEA WEO 2021 SDS regional", "IEA WEO 2021 SPS regional"),
pmatch = T
] <- NA
histData[,,"IEA WEO 2021", pmatch = T] <- histData.WEO
}

correctly to remove all data for scenarios IEA WEO 2021 APS GLO, IEA WEO 2021 Net2050 GLO, IEA WEO 2021 SDS GLO, IEA WEO 2021 SPS GLO, except for global (World) data, and all global data for scenarios IEA WEO 2021 APS regional, IEA WEO 2021 SDS regional, IEA WEO 2021 SPS regional, but not the regional?

@fbenke-pik
Copy link
Contributor

fbenke-pik commented Jan 26, 2022

Correct, this was an attempt to deal with the same issue brought up in issue #194 for the IEA WEO 2021 data.
It does not have to be adapted to the new cs2 script for now, I have decided to remove Global data together with inaccurate regional data in calcHistorical, so it won't be in new versions of historical.mif.

I am currently talking with @LaviniaBaumstark about a long-term solution that make these workarounds unnecessary altogether.

@fbenke-pik fbenke-pik requested a review from chroetz January 26, 2022 13:28
@fbenke-pik
Copy link
Contributor

Added Christof to list of reviewers, since he was involved in the discussion which led to removing IEA WEO 2021 and should be aware we brought back pre-filtering for IEA ETP data since we need it now for current industry validation .

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the dev/cs2_filter_historic_data branch July 4, 2023 07:55
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q restored the dev/cs2_filter_historic_data branch July 4, 2023 07:55
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the dev/cs2_filter_historic_data branch July 4, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants