-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brick color scheme in calibration plots and other small changes #7
Brick color scheme in calibration plots and other small changes #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just wodering about the local path...
@@ -9,7 +9,7 @@ output: | |||
params: | |||
docTitle: "BRICK calibration report" | |||
cal: "BRICK_calibration_report.csv" | |||
path: "C:\\Users\\ricardar\\Documents\\Results\\BRICK\\calibration-tests\\extrElec-vin\\lowEhp1-2010-30Iter0_1A" | |||
path: "C:\\Users\\ricardar\\Documents\\Results\\BRICK\\calibration-tests\\extrElec-vin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not spotting this earlier. But can we avoid this local path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing to this. This is usually overwritten by plotBRICKCalib()
and only applies if the .Rmd
file is executed directly. But still doesn't look very nice. I'll pass the current working directory instead.
I also fixed a naming inconsistency (function I noticed that knitting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you!
mip::plotstyle()
.