Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brick color scheme in calibration plots and other small changes #7

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

ricardarosemann
Copy link
Contributor

  • Adopt the Brick color schemes in calibration plots and additionally include specific color for "no change" renovation flows, both via mip::plotstyle().
  • Flexibilize the framework to generate calibration plots: Now allows to pass facets and extending the y-axis to zero can now be inactivated.
  • Correct output file name and one error message when generating the plots.

Copy link
Collaborator

@robinhasse robinhasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wodering about the local path...

@@ -9,7 +9,7 @@ output:
params:
docTitle: "BRICK calibration report"
cal: "BRICK_calibration_report.csv"
path: "C:\\Users\\ricardar\\Documents\\Results\\BRICK\\calibration-tests\\extrElec-vin\\lowEhp1-2010-30Iter0_1A"
path: "C:\\Users\\ricardar\\Documents\\Results\\BRICK\\calibration-tests\\extrElec-vin"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not spotting this earlier. But can we avoid this local path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing to this. This is usually overwritten by plotBRICKCalib() and only applies if the .Rmd file is executed directly. But still doesn't look very nice. I'll pass the current working directory instead.

@ricardarosemann
Copy link
Contributor Author

I also fixed a naming inconsistency (function plotBRICKCalib() vs. file name plotBRICKcalib.R), restricted the dplyr import to the required functions and adjusted further defaults in the header of the .Rmd file.

I noticed that knitting the .Rmd file directly does not work properly, because it cannot find readBrickSets() (I guess because it is not exported). But I figure this is a very rare use case, so I don't think this will be a problem.

Copy link
Collaborator

@robinhasse robinhasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@ricardarosemann ricardarosemann merged commit e7d203f into pik-piam:main Jun 19, 2024
2 checks passed
@ricardarosemann ricardarosemann deleted the color-calibration branch June 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants