Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataObject] Grid Export - Catch unable to read file exception #342

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[DataObject] Grid Export - Catch unable to read file exception #342

merged 2 commits into from
Nov 9, 2023

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Nov 8, 2023

No description provided.

@dvesh3 dvesh3 added the Bug label Nov 8, 2023
@dvesh3 dvesh3 added this to the 1.2.1 milestone Nov 8, 2023
@kingjia90 kingjia90 self-assigned this Nov 9, 2023
kingjia90

This comment was marked as resolved.

Sign in to view

@dvesh3
Copy link
Contributor Author

dvesh3 commented Nov 9, 2023

LGTM, but the same fix for Assets would be missing

admin-ui-classic-bundle/src/Controller/Admin/Asset/AssetHelperController.php

Line 758 in 2657473

$fileStream = $storage->readStream($csvFile);

@kingjia90 Good catch. Added the try catch for assets too.

@kingjia90 kingjia90 merged commit 10d178e into 1.2 Nov 9, 2023
7 checks passed
@kingjia90 kingjia90 deleted the grid_export_catch_unabletoreadfile branch November 9, 2023 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 requested changes

Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dvesh3 @kingjia90