Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Video Element not working #785

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix: Video Element not working #785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a5f79c
Fix: Video Element not working
blankse Dec 9, 2024
bc27f04
data.allowedTypes is already correct from PHP class
blankse Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion public/js/pimcore/document/editables/video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ pimcore.document.editables.video = Class.create(pimcore.document.editable, {
initialize: function($super, id, name, config, data, inherited) {
$super(id, name, config, data, inherited);

data.allowedTypes = config.allowedTypes;
Copy link
Contributor

@jdreesen jdreesen Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just added in #747. We should probably take another look at this ticket as well.

/cc @roland4432

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roland4432 @jdreesen The allowedTypes are already set from the config on the data in the editable php file. See https://github.com/pimcore/pimcore/blob/38728393ce02dfaa532f54c4fe99731b26638747/models/Document/Editable/Video.php#L1001

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roland4432 What was your allowedTypes configuration? Could it be that you used a wrong type in your array? Only an array with the values "asset", "youtube", "vimeo", and "dailymotion" is allowed. Otherwise, the configuration will be ignored. I think we should throw an exception when an incorrect type is used, rather than silently ignoring the configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should throw an exception when an incorrect type is used, rather than silently ignoring the configuration.

👍

this.data = data;
},

Expand Down
Loading