sonarcloud

pimcore · Nov 27, 2024 · 0d10458 · 0d10458
1 parent f1a5d58
commit 0d10458
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/Controller/Admin/ActivitiesController.php b/src/Controller/Admin/ActivitiesController.php
@@ -94,7 +94,8 @@ public function listAction(Request $request, CustomerProviderInterface $customer
      */
     public function detailAction(Request $request): Response
     {
-        $activity = \Pimcore::getContainer()->get('cmf.activity_store')->getEntryById($request->query->getInt('activityId'));
+        $activityId = $request->query->getInt('activityId');
+        $activity = \Pimcore::getContainer()->get('cmf.activity_store')->getEntryById($activityId);
 
         return $this->render(
             '@PimcoreCustomerManagementFramework/admin/activities/detail.html.twig',

diff --git a/src/Controller/Admin/CustomersController.php b/src/Controller/Admin/CustomersController.php
@@ -605,7 +605,8 @@ protected function addFilterDefinitionSegments(Request $request, array $filters)
         }
 
         // set to filter which segments to show
-        $filters['showSegments'] = $request->query->getString('apply-segment-selection') ? $filters['showSegments'] : $filterDefinition->getShowSegments();
+        $segmentSelection = $request->query->getString('apply-segment-selection');
+        $filters['showSegments'] = $segmentSelection ? $filters['showSegments'] : $filterDefinition->getShowSegments();
 
         // return merged filters array
         return $filters;

diff --git a/src/RESTApi/SegmentsHandler.php b/src/RESTApi/SegmentsHandler.php
@@ -178,7 +178,7 @@ public function updateRecord(Request $request)
             return new Response(
                 [
                     'success' => false,
-                    'msg' => sprintf('segment with id %s not found', $id),
+                    'msg' => 'segment with id ' . $id . ' not found',
                 ],
                 Response::RESPONSE_CODE_NOT_FOUND
             );