[Feature] Add SQL Data Source #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @msoroka Unfortunately the static analysis failed, could you please recheck your code and fix the tests. |
|
Hey @msoroka are you still working on this? It seems like a pretty cool feature, but with failing tests we cannot merge it. Could you give me a quick comment, that you are going to fix this? Otherwise I will close the PR in a week. If you still want this, we can reopen the PR anytime then. |
|
@mattamon Yes, I'll do it till end of this week. |
Awesome thank you! |
msoroka
force-pushed
the
1.x
branch
2 times, most recently
from
428443f to
be5b90c
Compare
|
@mattamon Done |
mattamon
requested changes
Sep 9, 2024
mattamon
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally created by LemonMind and TorqIT on Data Importer Extension.
All explained in attached docs.