Fix JavaScript error "Uncaught TypeError" when menu is disabled in perspective #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thy very much. could you please rebase to 1.0 branch. |
|
Hi @fashxp , I created a new PR #25 based on 1.0 branch as I was not able to rebase without getting additional commits from 1.x moved to 1.0. It was much easier to create new PR as there is anyhow just one change in single file. Sorry for that, but I think you will have to set labels and milestone assignment for the new PR |
|
no worries, thx very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #23 by checking existence of
menu.extrasbefore using it. It will not be available in case the extras menu is disabled in perspective configuration