Skip to content

Return type fixes + minor code improvements #21

Return type fixes + minor code improvements

Return type fixes + minor code improvements #21

Triggered via push January 15, 2024 11:54
Status Failure
Total duration 59s
Artifacts 1
Matrix: Static Analysis with PHPStan
Fit to window
Zoom out
Zoom in

Annotations

5 errors, 102 warnings, and 63 notices
Static Analysis with PHPStan (8.2, highest, 11.x-dev as 11.99.9, true): src/DependencyInjection/Configuration.php#L38
Call to an undefined method Symfony\Component\Config\Definition\Builder\NodeParentInterface::scalarNode().
Static Analysis with PHPStan (8.2, highest, 11.x-dev as 11.99.9, true)
Process completed with exit code 1.
Static Analysis with PHPStan (8.2, highest, false): src/DependencyInjection/Configuration.php#L38
Call to an undefined method Symfony\Component\Config\Definition\Builder\NodeParentInterface::scalarNode().
Static Analysis with PHPStan (8.2, highest, false)
The operation was canceled.
Static Analysis with PHPStan (8.1, lowest, false)
The operation was canceled.
Static Analysis with PHPStan (8.2, highest, 11.x-dev as 11.99.9, true)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Static Analysis with PHPStan (8.2, highest, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Static Analysis with PHPStan (8.1, lowest, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L198
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L102
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L143
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L155
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L277
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L211
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L321
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L113
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L123
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L45
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L164
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L122
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L168
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L99
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L267
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L126
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L145
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L58
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/DependencyInjection/Compiler/SearchIndexFieldDefinitionPass.php#L30
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L58
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L46
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L321
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L267
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L48
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L47
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L69
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L246
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L81
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L156
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L269
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L156
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L140
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Enum/DependencyInjection/CompilerPassTag.php#L18
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L69
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L122
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L64
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L113
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L89
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/DataObject/FieldDefinitionService.php#L16
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L95
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L45
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L46
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L47
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L395
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/DependencyInjection/Compiler/SearchIndexFieldDefinitionPass.php#L29
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L106
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L95
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L81
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L143
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L81
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L89
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L145
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L90
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L140
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L81
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L167
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L269
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L303
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L89
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L81
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L90
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L126
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/DataObject/FieldDefinitionService.php#L16
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L262
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/DependencyInjection/Compiler/SearchIndexFieldDefinitionPass.php#L29
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L89
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L155
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L262
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L254
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L111
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L100
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Enum/DependencyInjection/CompilerPassTag.php#L18
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L303
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L403
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L168
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L111
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L247
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AssetIndexService.php#L99
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L167
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L247
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L106
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L93
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L277
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L127
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L254
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexQueueService.php#L267
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Command/Update/IndexUpdateCommand.php#L48
Line is longer than allowed by code style (\> 120 columns)
Line is longer than allowed by code style: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L246
Line is longer than allowed by code style (\> 120 columns)
Missing return type declaration: src/Command/Update/IndexUpdateCommand.php#L41
Missing function's return type declaration
Missing return type declaration: src/PimcoreGenericDataIndexBundle.php#L31
Missing function's return type declaration
Missing return type declaration: src/Traits/LoggerAwareTrait.php#L24
Missing function's return type declaration
Missing return type declaration: src/Command/Update/IndexUpdateCommand.php#L59
Missing function's return type declaration
Static methods invocation via '->': src/DependencyInjection/PimcoreGenericDataIndexExtension.php#L54
\[EA\] '...::parseFile(...)' should be used instead.
Class overrides a field of a parent class: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/SelectAdapter.php#L26
\[EA\] Field 'fieldDefinition' is already defined in \\Pimcore\\Bundle\\GenericDataIndexBundle\\Service\\SearchIndex\\DataObject\\FieldDefinitionAdapter\\DefaultAdapter, check our online documentation for options.
Class overrides a field of a parent class: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/MultiSelectAdapter.php#L26
\[EA\] Field 'fieldDefinition' is already defined in \\Pimcore\\Bundle\\GenericDataIndexBundle\\Service\\SearchIndex\\DataObject\\FieldDefinitionAdapter\\DefaultAdapter, check our online documentation for options.
Class overrides a field of a parent class: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/LocalizedFieldsAdapter.php#L28
\[EA\] Field 'fieldDefinition' is already defined in \\Pimcore\\Bundle\\GenericDataIndexBundle\\Service\\SearchIndex\\DataObject\\FieldDefinitionAdapter\\DefaultAdapter, check our online documentation for options.
'isset(...)' constructs can be merged: src/Service/SearchIndex/IndexService/AssetIndexService.php#L178
\[EA\] This can be merged into the previous 'isset(..., ...\[, ...\])'.
JSON encoding API usage: src/Service/SearchIndex/IndexService/AssetIndexService.php#L117
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/DefaultAdapter.php#L86
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L154
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/IndexService/AssetIndexService.php#L136
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L205
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L218
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/IndexService/DataObjectIndexService.php#L188
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L57
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L166
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
JSON encoding API usage: src/Service/SearchIndex/OpenSearch/BulkOperationService.php#L54
\[EA\] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this call options.
Fully qualified name usage: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L36
Qualifier can be replaced with an import
Case mismatch in method call or class usage: src/Service/SearchIndex/IndexService/AssetIndexService.php#L163
Case in function/method call doesn't match the case in declaration
Case mismatch in method call or class usage: src/Service/SearchIndex/DataObject/FieldDefinitionService.php#L30
Case in function/method call doesn't match the case in declaration
Case mismatch in method call or class usage: src/Service/SearchIndex/DataObject/FieldDefinitionService.php#L31
Case in function/method call doesn't match the case in declaration
Redundant catch clause: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L58
Exception 'Missing404Exception' is never thrown in the corresponding 'try' block
Redundant catch clause: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L71
Exception 'Missing404Exception' is never thrown in the corresponding 'try' block
Redundant @var tag: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/LocalizedFieldsAdapter.php#L76
@var tag specifies the type already inferred from source code
Redundant @var tag: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/DefaultAdapter.php#L94
@var tag specifies the type already inferred from source code
Redundant @var tag: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/LocalizedFieldsAdapter.php#L48
@var tag specifies the type already inferred from source code
Static method called as dynamic: src/DependencyInjection/PimcoreGenericDataIndexExtension.php#L54
Static method 'parseFile' should not be called dynamically
Redundant cast to boolean: src/Service/SearchIndex/DataObject/FieldDefinitionAdapter/BooleanAdapter.php#L34
Unnecessary cast to '(bool)$this-\>doGetRawIndexDataValue($object)'
Unused local variable: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L58
Unused local variable 'e'. The value of the variable is not used anywhere.
Unused local variable: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L71
Unused local variable 'e'. The value of the variable is not used anywhere.
Return type hint can be used: src/DependencyInjection/PimcoreGenericDataIndexExtension.php#L62
\[EA\] ': PimcoreGenericDataIndexExtension' can be declared as return type hint.
Return type hint can be used: src/DependencyInjection/PimcoreGenericDataIndexExtension.php#L48
\[EA\] ': void' can be declared as return type hint (please use change signature intention to fix this).
Return type hint can be used: src/Command/Update/IndexUpdateCommand.php#L41
\[EA\] ': void' can be declared as return type hint (please use change signature intention to fix this).
Return type hint can be used: src/Command/Update/IndexUpdateCommand.php#L59
\[EA\] ': int' can be declared as return type hint (please use change signature intention to fix this).
Return type hint can be used: src/PimcoreGenericDataIndexBundle.php#L31
\[EA\] ': void' can be declared as return type hint (please use change signature intention to fix this).
Return type hint can be used: src/DependencyInjection/Compiler/SearchIndexFieldDefinitionPass.php#L26
\[EA\] ': void' can be declared as return type hint (please use change signature intention to fix this).
Return type hint can be used: src/Traits/LoggerAwareTrait.php#L24
\[EA\] ': void' can be declared as return type hint.
Static closure can be used: src/Service/SearchIndex/IndexService/AbstractIndexService.php#L174
\[EA\] This closure can be declared as static (better scoping; in some cases can improve performance).
General exception is thrown: src/Service/SearchIndex/OpenSearch/OpenSearchService.php#L136
\[EA\] \\Exception is too general. Consider throwing one of SPL exceptions instead.
General exception is thrown: src/Command/Update/IndexUpdateCommand.php#L78
\[EA\] \\Exception is too general. Consider throwing one of SPL exceptions instead.
General exception is thrown: src/Command/Update/IndexUpdateCommand.php#L62
\[EA\] \\Exception is too general. Consider throwing one of SPL exceptions instead.

Artifacts

Produced during runtime
Name Size
phpstan-baseline.neon Expired
243 Bytes