Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite default failure transport #238

Closed
morgannilsson opened this issue Oct 31, 2024 · 4 comments · Fixed by #261
Closed

Do not overwrite default failure transport #238

morgannilsson opened this issue Oct 31, 2024 · 4 comments · Fixed by #261

Comments

@morgannilsson
Copy link
Contributor

morgannilsson commented Oct 31, 2024

generic-data-index-bundle/config/pimcore/messenger.yaml

framework:
    messenger:
        enabled: true
        failure_transport: pimcore_generic_data_index_failed

Should be:

framework:
    messenger:
        transports:
            pimcore_generic_data_index:
                dsn: "doctrine://default?queue_name=pimcore_generic_data_index_queue"
                failure_transport: pimcore_generic_data_index_failed
@morgannilsson morgannilsson changed the title Do not over default failure transport Do not overwrite default failure transport Nov 1, 2024
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

@morgannilsson
Copy link
Contributor Author

PR created: #258

@morgannilsson
Copy link
Contributor Author

New PR for 1.2 branch: 261

@lukmzig lukmzig linked a pull request Nov 25, 2024 that will close this issue
@mattamon
Copy link
Contributor

mattamon commented Dec 2, 2024

Resolved by #261

@mattamon mattamon closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants