Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite default failure transport #261

Merged

Conversation

morgannilsson
Copy link
Contributor

Changes in this pull request

Resolves #238

Additional info

Copy link

github-actions bot commented Nov 25, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lukmzig
Copy link
Contributor

lukmzig commented Nov 25, 2024

@morgannilsson thank you, could you please post a comment with only
I have read the CLA Document and I hereby sign the CLA
to sign the CLA and trigger a recheck??

@lukmzig lukmzig added the Bug label Nov 25, 2024
@lukmzig lukmzig added this to the 1.2.3 milestone Nov 25, 2024
@lukmzig lukmzig linked an issue Nov 25, 2024 that may be closed by this pull request
@morgannilsson
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@lukmzig
Copy link
Contributor

lukmzig commented Nov 28, 2024

@morgannilsson thank you, it seems like this did not work. I see that for the commit you used this email address
morgan.nilsson@ateles.se. Is this email address added to your github account? It would be necessary to do so before signing the CLA. Thank you!

@morgannilsson
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me now!

@mattamon mattamon merged commit cc09b60 into pimcore:1.2 Dec 2, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not overwrite default failure transport
3 participants