Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Deleting objects/assets does not update generic data index #204

Merged

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Aug 27, 2024

Changes in this pull request

Resolves #201

Additional info

  • elements were not deleted from index since they are not existing in Pimcore anymore
  • pass correct operation to async queue updates

@lukmzig lukmzig added the Bug label Aug 27, 2024
@lukmzig lukmzig added this to the 1.1.4 milestone Aug 27, 2024
@lukmzig lukmzig requested a review from markus-moser August 27, 2024 13:40
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM but should we add some functional tests to ensure the deletion works?

@lukmzig
Copy link
Contributor Author

lukmzig commented Aug 27, 2024

It LGTM but should we add some functional tests to ensure the deletion works?

good point, I will add some more tests :)

Copy link

@lukmzig lukmzig requested a review from markus-moser August 28, 2024 07:06
@lukmzig lukmzig merged commit e9d1545 into 1.1 Aug 28, 2024
10 checks passed
@lukmzig lukmzig deleted the 201-bug-deleting-objectsassets-does-not-update-generic-data-index branch August 28, 2024 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants