Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PD-106] Change SQL statements to query builder syntax #21

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Feb 2, 2024

Changes in this pull request

Resolves https://pimcore.atlassian.net/browse/PD-106

@lukmzig lukmzig added the Task label Feb 2, 2024
@lukmzig lukmzig added this to the 1.0.0 milestone Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case if we have later more Repositories, would it make sense to extract methods like generateSelectQuery, or quoteParameters to a base or abstract class to re-use it later?

Or just do it when we need it?

@lukmzig
Copy link
Contributor Author

lukmzig commented Feb 2, 2024

In the case if we have later more Repositories, would it make sense to extract methods like generateSelectQuery, or quoteParameters to a base or abstract class to re-use it later?

Or just do it when we need it?

I would say we do it if we decide to do some base repository (when we see the need for it) wdyt?

@martineiber
Copy link
Contributor

In the case if we have later more Repositories, would it make sense to extract methods like generateSelectQuery, or quoteParameters to a base or abstract class to re-use it later?
Or just do it when we need it?

I would say we do it if we decide to do some base repository (when we see the need for it) wdyt?

Sounds good :)

Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lukmzig lukmzig merged commit ecddacc into 1.x Feb 2, 2024
10 checks passed
@lukmzig lukmzig deleted the PD-106-use-query-builder branch February 2, 2024 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants