-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PD-106] Change SQL statements to query builder syntax #21
Conversation
Qodana for PHPIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case if we have later more Repositories, would it make sense to extract methods like generateSelectQuery
, or quoteParameters
to a base or abstract class to re-use it later?
Or just do it when we need it?
I would say we do it if we decide to do some base repository (when we see the need for it) wdyt? |
Sounds good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Changes in this pull request
Resolves https://pimcore.atlassian.net/browse/PD-106