Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-98 Tackle Qodana Issues. Pt.1 #6

Merged
merged 21 commits into from
Jan 30, 2024
Merged

PD-98 Tackle Qodana Issues. Pt.1 #6

merged 21 commits into from
Jan 30, 2024

Conversation

martineiber
Copy link
Contributor

Changes in this pull request

Resolves https://pimcore.atlassian.net/browse/PD-98

Additional info

@martineiber martineiber added this to the 1.0.0 milestone Jan 29, 2024
Copy link

github-actions bot commented Jan 29, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

martineiber and others added 3 commits January 29, 2024 15:25
# Conflicts:
#	src/Service/SearchIndex/OpenSearch/BulkOperationService.php
@martineiber martineiber changed the title PD-98 Tackle Qodana Issues. PD-98 Tackle Qodana Issues. Pt.1 Jan 29, 2024
@martineiber martineiber marked this pull request as ready for review January 30, 2024 12:54
Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martineiber martineiber merged commit f554df4 into 1.x Jan 30, 2024
10 checks passed
@martineiber martineiber deleted the PD-98-fix-qodana branch January 30, 2024 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants